Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requires in *-platform modules #900

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

HGuillemet
Copy link
Collaborator

@HGuillemet HGuillemet commented Jun 27, 2020

This PR allows an app to have a *-platform module in its module graph without bringing into the graph all existing implementations of the native library.

Meant to work with the use of javacpp.plaform property and the new additions to javafx-maven-plugin.

See Add option to populate module path with all maven dependencies #91

@HGuillemet HGuillemet changed the title Remove requires in -platform modules Remove requires in *-platform modules Jun 27, 2020
@HGuillemet
Copy link
Collaborator Author

I'm not sure if it's normal than the requires towards the macos module is commented out in the cuda presets.

@saudet
Copy link
Member

saudet commented Jun 27, 2020

I'm not sure if it's normal than the requires towards the macos module is commented out in the cuda presets.

Yes, CUDA no longer supports Mac, but some users may want to backport some stuff to older versions, you never know...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants